[pull] main from libsdl-org:main#19
Merged
pull[bot] merged 6 commits intoMainbaseT:mainfrom Dec 12, 2024
Merged
Conversation
SDL process is using `posix_spawnp` which already does the path lookup so additional indirection via `env` is unnecessary
Simplifies logic of spawning the zenity process by avoiding allocations of static strings
Introduce `const` where appropriate
SDL properties passed to the `SDL_Zenity_ShowFileDialogWithProperties` may be destroyed/modified immediately upon the function return. Therefore, we must copy all the strings and structures passed via pointers; otherwise, the `SDL_ZenityFileDialog` thread attempting to read them will cause data race.
Creating `argv` for zenity means we don't have to pass the building blocks between threads which allows us to avoid deep copying some nested structures. It also allows us to fail earlier in case of problems with building the argument vector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )