Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the logging system and documentation by adding file logging support, deprecating the unused utils/logs.go module, enhancing log configuration, and updating documentation to reflect these changes.
- Added dual output logging (stdout + file) with graceful fallback when file writing fails
- Added a new helper function
GetDirfor extracting directory paths from file paths - Improved log verbosity controls with startup configuration summaries and reduced noise in reset operations
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/utils/logs.go | Added deprecation notice for unused logging module |
| pkg/utils/helper.go | Added GetDir function for file path directory extraction |
| pkg/immich/client.go | Improved logging for stack reset operations with better verbosity control |
| docs/integration/docker.md | Updated documentation to clarify file logging configuration |
| docs/integration/docker-compose.md | Enhanced documentation with logging configuration examples |
| docs/getting-started/quick-start.md | Added file logging examples to quick start guide |
| docs/api-reference/environment-variables.md | Expanded logging documentation with file logging details |
| docker-compose.yml | Updated comments to clarify logging configuration |
| cmd/config_test.go | Added comprehensive tests for logging configuration |
| cmd/config.go | Implemented file logging support and startup configuration summary |
| README.md | Added logging examples and clarifications |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on fixing logs, see #34