Skip to content

fix: improve log system and doc#36

Merged
Majorfi merged 2 commits intomainfrom
feat/log-improvements
Sep 14, 2025
Merged

fix: improve log system and doc#36
Majorfi merged 2 commits intomainfrom
feat/log-improvements

Conversation

@Majorfi
Copy link
Copy Markdown
Owner

@Majorfi Majorfi commented Sep 14, 2025

Working on fixing logs, see #34

@Majorfi Majorfi requested a review from Copilot September 14, 2025 21:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the logging system and documentation by adding file logging support, deprecating the unused utils/logs.go module, enhancing log configuration, and updating documentation to reflect these changes.

  • Added dual output logging (stdout + file) with graceful fallback when file writing fails
  • Added a new helper function GetDir for extracting directory paths from file paths
  • Improved log verbosity controls with startup configuration summaries and reduced noise in reset operations

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/utils/logs.go Added deprecation notice for unused logging module
pkg/utils/helper.go Added GetDir function for file path directory extraction
pkg/immich/client.go Improved logging for stack reset operations with better verbosity control
docs/integration/docker.md Updated documentation to clarify file logging configuration
docs/integration/docker-compose.md Enhanced documentation with logging configuration examples
docs/getting-started/quick-start.md Added file logging examples to quick start guide
docs/api-reference/environment-variables.md Expanded logging documentation with file logging details
docker-compose.yml Updated comments to clarify logging configuration
cmd/config_test.go Added comprehensive tests for logging configuration
cmd/config.go Implemented file logging support and startup configuration summary
README.md Added logging examples and clarifications

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Majorfi Majorfi merged commit f8100f1 into main Sep 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants