Added account creation and login for Guest and Host#12
Merged
Prakhar896 merged 15 commits intomainfrom Jun 23, 2024
Merged
Conversation
Sync-up PR (Jun Han)
Sync-up PR (Jun Han)
…gh validations to ensure unique username and email across all accounts. Updated login account to handle all accounts and return with the account type.
…ccount recovery backend.
Prakhar896
requested changes
Jun 22, 2024
Prakhar896
requested changes
Jun 23, 2024
Contributor
Prakhar896
left a comment
Prakhar896
left a comment
There was a problem hiding this comment.
Great work on rectifications. Just a few standardisation things left.
Additional: Consider adding Logger.log messages at critical endpoints like reset password and stuff.
Prakhar896
requested changes
Jun 23, 2024
| const { Guest, Host, Admin } = require('../../models'); | ||
| const { Universal, Emailer, Encryption } = require('../../services') | ||
| const { Universal, Emailer, Encryption, Logger } = require('../../services'); | ||
| const { logger } = require('sequelize/lib/utils/logger'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can create a guest or host account and log in using their credentials. Users can also recover their accounts using a reset key, which will be emailed to the user.
Added resetKey and resetKeyExpiration to Guest, Host and Admin