Skip to content

Optimised back-end server routes, implemented database integration and functionality testing of server routes#22

Merged
Prakhar896 merged 25 commits intomainfrom
lincoln
Jun 28, 2024
Merged

Optimised back-end server routes, implemented database integration and functionality testing of server routes#22
Prakhar896 merged 25 commits intomainfrom
lincoln

Conversation

@lincoln0623
Copy link
Copy Markdown
Contributor

### Completion:

  1. Created dummy host and guest data for testing purposes.
  2. Added two get method in cdn/coreData.js to get all reviews (used for reviews fetching in the frontend afterwards) and specific reviews based on the reveiwID.
  3. Optimized review.js post method to creata a new review in database
  4. Optimized and tested using postCode for both put and delete method route (All working fine)

@lincoln0623 lincoln0623 requested a review from Prakhar896 June 27, 2024 06:54
@lincoln0623 lincoln0623 self-assigned this Jun 27, 2024
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poor coding practices are being used; I encourage you to consistently check your own code for vulnerabilities, redundancy and consistency. See comments for items of action.

Comment thread index.js Outdated
Comment thread index.js Outdated
Comment thread index.js Outdated
Comment thread index.js Outdated
Comment thread index.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
@Prakhar896 Prakhar896 added the enhancement New feature or request label Jun 27, 2024
@lincoln0623 lincoln0623 requested a review from Prakhar896 June 27, 2024 14:08
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make your changes consistently and cognitively please.

Comment thread routes/cdn/coreData.js Outdated
Comment thread routes/cdn/coreData.js Outdated
Comment thread routes/cdn/coreData.js Outdated
Comment thread routes/cdn/coreData.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Comment thread routes/reviews/reviews.js Outdated
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prakhar896 Prakhar896 merged commit 7f829c1 into main Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants