Merged
Conversation
Sync-up PR (Nicholas)
Sync-up PR (Nicholas)
Contributor
|
Bro why don't you have any PR notes? @nicholascheww |
Prakhar896
reviewed
Jun 27, 2024
Contributor
Prakhar896
left a comment
Prakhar896
left a comment
There was a problem hiding this comment.
Impressive and very well-written. Just one question, see my comment.
| ws.send(JSON.stringify(message)); | ||
| } | ||
|
|
||
| ws.on("message", (message) => { |
Contributor
There was a problem hiding this comment.
Is this supposed to be nested in the wss.on("connection") thing? I'm unsure so just asking and double-checking.
Contributor
Author
There was a problem hiding this comment.
yes cause when they reach the /chat endpoint they will connect to the ws server, which i want the messaged to be rendered then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.