Skip to content

Association and new endpoint for image fetching#32

Merged
lincoln0623 merged 5 commits intomainfrom
lincoln
Jul 3, 2024
Merged

Association and new endpoint for image fetching#32
lincoln0623 merged 5 commits intomainfrom
lincoln

Conversation

@lincoln0623
Copy link
Copy Markdown
Contributor

@lincoln0623 lincoln0623 commented Jun 29, 2024

### Sensitive Changes

  • I'd made some changes to the model files to associate both reviews and guest model to fetch both reviews and guest data in a shot in coreData.js -> getReviews route

### Completion

  • Removed redundant and outdated 'guest' dummy data
  • Added and Tested out getImageForReview route to fetch all the image data url for frontend
  • Added Logger.log for error handling and set ambiguous UERROR to ERROR
  • Change to the correct middleware to save file images (commented out section is for further development purposes which will fetch guest and host id from url query / parameters to use in the data form for review submit)
  • Some Minor Changes :
    -Removed unused field in the post method (sender and receiver)
    -Added a few accepting field for updating the review ( used in like reviews)

### Question!
Since last PR until now, I haven't get the FK constraint error anymore. How did we get the error last time we tried it out before the code review? I would like to know on how to reproduce the error again in purpose to address the error correctly.

@lincoln0623 lincoln0623 requested a review from Prakhar896 June 29, 2024 12:33
@lincoln0623 lincoln0623 self-assigned this Jun 29, 2024
@lincoln0623 lincoln0623 merged commit bf65d13 into main Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant