Skip to content

Optimized Review Page Endpoint Routing, New Like Review Endpoint and ReviewLike Modal#44

Merged
Prakhar896 merged 29 commits intomainfrom
lincoln
Jul 11, 2024
Merged

Optimized Review Page Endpoint Routing, New Like Review Endpoint and ReviewLike Modal#44
Prakhar896 merged 29 commits intomainfrom
lincoln

Conversation

@lincoln0623
Copy link
Copy Markdown
Contributor

Overview of Changes

  • Used automated route registration at index.js
  • Removed unnecessary Logger.log
  • Deleted review.js and separated into three different files hostReview.js, submitReview.js and manageReviews.js

Sensitive Changes

  • Resolved FK constraint error at FoodListing.js modal
  • Created ReviewLike Modal ReviewLike.js
  • Modified modals Host.js, Guest.js and Review.js
  • Modified models/index.js to import the right model.

@lincoln0623 lincoln0623 requested a review from Prakhar896 July 8, 2024 09:14
@lincoln0623 lincoln0623 self-assigned this Jul 8, 2024
@Prakhar896 Prakhar896 added the enhancement New feature or request label Jul 8, 2024
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the ReviewLike workaround. Unfortunately, it won't last very long, need to change to a proper junction table. See comments for more details. It'll help ensure consistency in the future and reduce debugging issues. Great work all around and props for the code organisation and improved coding practices.

Comment thread models/Guest.js
Comment thread models/Host.js
Comment thread models/Review.js
Comment thread models/ReviewLike.js
Comment thread routes/cdn/contentDelivery.js
Comment thread routes/reviews/likeReview.js Outdated
Comment thread routes/reviews/likeReview.js Outdated
Comment thread routes/reviews/manageReviews.js Outdated
Comment thread routes/reviews/manageReviews.js Outdated
Comment thread routes/reviews/submitReview.js
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 11, 2024 05:10
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prakhar896 Prakhar896 merged commit 89f9ad5 into main Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants