Removed dummy data, fixed bugs, updated FoodListing Model and added extra error handling#57
Merged
Prakhar896 merged 13 commits intomainfrom Jul 19, 2024
Merged
Removed dummy data, fixed bugs, updated FoodListing Model and added extra error handling#57Prakhar896 merged 13 commits intomainfrom
Prakhar896 merged 13 commits intomainfrom
Conversation
Sync-up PR (Joshua)
Sync-up PR (Joshua)
… /addListing, added include for /listings as Host
…vourite their own listing now
Prakhar896
requested changes
Jul 15, 2024
…vourite route to accept lesser params and be smarter in determining the user type
Prakhar896
requested changes
Jul 19, 2024
Contributor
Prakhar896
left a comment
Prakhar896
left a comment
There was a problem hiding this comment.
Really well-written. Some consistency and standardisation issues only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done in this PR
1.) Removed hardcoded data and dummy data creation in
onDBSynchronise2.) Fixed bug in
LoginAccount, see below3.) Hosts are now unable to favourite their own listing
4.) Added
coordinatesinFoodListingModel5.) Fixed bugs
Sensitive changes
1.) Added
coordinatesinFoodListingModel2.) Modified
userInfoinbackend/routes/identity/LoginAccountby removing theuser.prefix beforeuserType. This is a fix by @JunHammy for a bug that was discovered recently.---END OF PR---