Skip to content

Like Review Endpoint Optimization#70

Merged
Prakhar896 merged 18 commits intomainfrom
lincoln
Jul 23, 2024
Merged

Like Review Endpoint Optimization#70
Prakhar896 merged 18 commits intomainfrom
lincoln

Conversation

@lincoln0623
Copy link
Copy Markdown
Contributor

Overview of Changes

  • Sync-up changes in auth.js
  • Retrieve review ID for liked reviews from a user
  • Optimized likeReview post method for better efficiency
  • Applied validateToken to validate user before performing edit and delete review actions

@lincoln0623 lincoln0623 added the enhancement New feature or request label Jul 22, 2024
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 22, 2024 04:39
@lincoln0623 lincoln0623 self-assigned this Jul 22, 2024
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well written, just one or two changes.

Comment thread routes/cdn/coreData.js
Comment thread routes/reviews/likeReview.js
Comment thread routes/reviews/manageReviews.js
Comment thread routes/reviews/manageReviews.js
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 22, 2024 17:42
Comment thread routes/reviews/manageReviews.js Outdated
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small authorisation check required. Always remember to ensure that the client is authorised before allowing them to perform sensitive transactions.

Comment thread routes/reviews/manageReviews.js
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 23, 2024 06:59
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorisation checks are done inappropriately. See comments.

Comment thread routes/reviews/manageReviews.js
Comment thread routes/reviews/manageReviews.js
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 23, 2024 12:13
Comment thread routes/reviews/manageReviews.js Outdated
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 23, 2024 12:51
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prakhar896 Prakhar896 merged commit 6382e8b into main Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants