Skip to content

Added changing of lname and fname, modified endpoints for calendar ui#76

Merged
Prakhar896 merged 14 commits intomainfrom
junhan
Jul 26, 2024
Merged

Added changing of lname and fname, modified endpoints for calendar ui#76
Prakhar896 merged 14 commits intomainfrom
junhan

Conversation

@JunHammy
Copy link
Copy Markdown
Contributor

@JunHammy JunHammy commented Jul 24, 2024

What was done in this PR

  1. Address is concatenated from the 4 attributes (blkNo, unitNo, street and postalCode)
  2. Address validated by google maps api when creating an account
  3. Added endpoint to facilitate the changing of first / last name for my account page
  4. Modified include clause in listing endpoint

Sensitive changes

  1. Added fname and lname attributes to Admin, Guest and Host models
  2. Added fname and lname attributes to dummy data

Prakhar896 and others added 11 commits July 20, 2024 00:50
@Prakhar896
Merge pull request #62 from MakanMatch/main
37ee168 
Sync-up PR (Jun Han)
@Prakhar896
Merge pull request #66 from MakanMatch/main
1da134e 
Sync-up PR (Jun Han)
@JunHammy
Fixed format of address when account is created
ca02da9
@JunHammy @Sadliquid
Added validation for address in create account
8971698 
Co-authored-by: Joshua Long  <Sadliquid@users.noreply.github.com>
@JunHammy
Validated datetime in listing.js
f6f5473
@JunHammy
added fname and lname to Guest, Host, Admin models and create account…
c2a9079 
… endpoint. added sample fname and lname for sample host and guest.
@JunHammy
Added fname and lname validation
c2d2da6
@JunHammy
Added backend for get profile picture
0a4a8b0
@JunHammy @Sadliquid
refined include caluse for listings
5a08ca0 
Co-authored-by: Joshua Long  <Sadliquid@users.noreply.github.com>
@JunHammy
Added change name to my account to change fname and lname
e2d744e
@JunHammy
Store address to cater to optional blkNo and unitNum field
71ce5b1
@Prakhar896 Prakhar896 added the enhancement New feature or request label Jul 25, 2024
@JunHammy JunHammy requested a review from Prakhar896 July 25, 2024 08:58
Prakhar896
Prakhar896 requested changes Jul 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work all around. Really well-written code. Need some consistency chances.

Comment thread routes/cdn/contentDelivery.js Outdated
Comment thread routes/cdn/coreData.js Outdated
Comment thread routes/identity/CreateAccount.js Outdated
Comment thread routes/identity/CreateAccount.js Outdated
Comment thread routes/identity/CreateAccount.js Outdated
Comment thread routes/identity/myAccount.js Outdated
Comment thread routes/identity/myAccount.js Outdated
Comment thread routes/identity/myAccount.js
Comment thread routes/identity/myAccount.js Outdated
Comment thread routes/listings/listings.js
@JunHammy JunHammy requested a review from Prakhar896 July 26, 2024 05:28
Prakhar896
Prakhar896 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prakhar896 Prakhar896 merged commit 5ec5dfa into main Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prakhar896 Prakhar896 Prakhar896 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JunHammy @Prakhar896