Skip to content

Favourite Listing Backend Router Endpoint#82

Merged
Prakhar896 merged 13 commits intomainfrom
lincoln
Jul 28, 2024
Merged

Favourite Listing Backend Router Endpoint#82
Prakhar896 merged 13 commits intomainfrom
lincoln

Conversation

@lincoln0623
Copy link
Copy Markdown
Contributor

Overview of Changes

  • favourites/getFavouritedListings to get all details including user record, user favourited listings and listing host details

  • listings/getFavouritedListingsID to get all favourited listings ID to determine the favourite state of a user for a listing, returning a list of favourited listingID by the user

  • listings//toggleFavouriteListing updated to apply userRecord table to fetch userRecordID to do favourite and unfavourite listings action

@lincoln0623 lincoln0623 added the enhancement New feature or request label Jul 27, 2024
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 27, 2024 10:16
@lincoln0623 lincoln0623 self-assigned this Jul 27, 2024
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some SQL transactions can be optimised with more complex transactions and queries.

Comment thread routes/identity/Favourites.js
Comment thread routes/listings/listings.js
Comment thread routes/listings/listings.js Outdated
Comment thread routes/listings/listings.js Outdated
Comment thread routes/listings/listings.js Outdated
Comment thread routes/listings/listings.js Outdated
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 28, 2024 03:02
Copy link
Copy Markdown
Contributor

@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prakhar896 Prakhar896 merged commit 87b715b into main Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants