Solid page header on /gift-cards#1070
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
orveth
force-pushed
the
fix/gift-cards-header-solid
branch
from
eaa32eb to
9aa63cb
Compare
jbojcic1
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the rest of the app's page-header pattern (e.g. transactions list) — header sits in normal flow with a solid background, content disappears at the header boundary instead of scrolling under a transparent floating header.
Single change in
app/features/gift-cards/gift-cards.tsx:PageHeaderno longerabsolute inset-x-0 top-0 z-20— sits in flex flow abovePageContentPageContentno longer needspt-16clearance for the floating header