Introduce spark accounts by gudnuf · Pull Request #699 · MakePrisms/agicash

gudnuf · 2025-11-05T22:49:46Z

This is a work in progress spark implementation based on this GDoc.

I've broken each piece up into their own commit

What I've Done

Defined a new account type for spark
poll spark balance
modified the upsert_user_with_accounts function to allow creating a user with just a Spark wallet.
Enforce that a user has 1 and only 1 Spark account
receive via lightning to a spark account through the UI
added spark to our LNURL server

What to do

Improve balance tracking so that it updates as soon as a receive completes. We might use the transfer:claimed event for this, but that would only work for receives
Implement spark lightning sends
Receive cashu tokens to a Spark account
Sync Spark transfers to the Agicash transactions table on app load and whenever a send or receive completes

Questions

How should we handle the Spark network? I wrote in the doc that we would have an environment variable, but then decided to define the network on the Spark account. If we will always assume mainnet for production then maybe we don't need to put the network on the account record and can just rely on an environment variable to toggle for development

vercel · 2025-11-05T22:49:54Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
agicash	Ready	Preview	Comment	Dec 4, 2025 10:55pm

supabase · 2025-11-05T22:50:04Z

Updates to Preview Branch (introduce-spark-accounts) ↗︎

Deployments	Status	Updated
Database	⚠️	Wed, 05 Nov 2025 22:54:38 UTC
Services	⚠️	Wed, 05 Nov 2025 22:54:38 UTC
APIs	⚠️	Wed, 05 Nov 2025 22:54:38 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks	Status	Updated
Configurations	❌	Wed, 05 Nov 2025 22:55:07 UTC
Migrations	⏸️	Wed, 05 Nov 2025 22:52:02 UTC
Seeding	⏸️	Wed, 05 Nov 2025 22:52:02 UTC
Edge Functions	⏸️	Wed, 05 Nov 2025 22:52:02 UTC

❌ Branch Error • Wed, 05 Nov 2025 22:55:08 UTC

unexpected status 403: {"message":"Forbidden resource"}

⚠️ Warning — Service health check failed

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

jbojcic1 · 2025-11-26T22:06:57Z

How should we handle the Spark network? I wrote in the doc that we would have an environment variable, but then decided to define the network on the Spark account. If we will always assume mainnet for production then maybe we don't need to put the network on the account record and can just rely on an environment variable to toggle for development

Putting it on the account would allow us to have different accounts for different networks. How likely that is?

supabase/migrations/20251125205840_add-spark-and-allow-one-account.sql

app/features/wallet/use-track-wallet-changes.ts

app/features/accounts/default-currency-switcher.tsx

jbojcic1 · 2025-11-26T22:10:51Z

app/features/accounts/account-repository.ts

+          unit: getDefaultUnit(commonData.currency),
+        }),
+        network: details.network,
+        isOnline: true,


should we make it offline if call to get balance fails?

Right now the wallet will crash if spark wallet fails to initialize. Instead of setting offline if get balance fails, would it be better to make it so that the wallet doesn't crash if initialization fails, and instead sets offline?

Maybe we should do both.

Btw, sometimes if the Spark infrastructure is having problems while we are in the middle of a receive the SDK will throw and crash the app. It seems like the internal logic of the SDK is throwing when it tries to claim the transfer, but I don't remember exactly

Right now the wallet will crash if spark wallet fails to initialize. Instead of setting offline if get balance fails, would it be better to make it so that the wallet doesn't crash if initialization fails, and instead sets offline?

Yeah I would say it's much nicer to show it as offline (Spark being offline shouldn't prevent me from spending my gift card for example). The problem is that we will not know the balance in that case. We could treat it as 0 but users might panic in that case as they would think they lost the money. Alternative is to store the last known balance to local storage (or even our db under account details) and use that and if not present show something other than number.

Btw, sometimes if the Spark infrastructure is having problems while we are in the middle of a receive the SDK will throw and crash the app. It seems like the internal logic of the SDK is throwing when it tries to claim the transfer, but I don't remember exactly

what exactly throws? can we catch it and where?

I don't remember, I will have to check next time it happens

app/features/accounts/account-hooks.ts

app/features/settings/accounts/$accountId.tsx

app/routes/_protected.receive.spark.$requestId.tsx

app/features/receive/lightning-address-service.tsx

app/features/accounts/account-hooks.ts

app/features/receive/lightning-address-service.tsx

app/features/settings/accounts/$accountId.tsx

app/routes/_protected.receive.spark.$requestId.tsx

supabase/migrations/20251125205840_add-spark-and-allow-one-account.sql

gudnuf · 2025-11-27T00:15:52Z

app/features/accounts/account-repository.ts

+          unit: getDefaultUnit(commonData.currency),
+        }),
+        network: details.network,
+        isOnline: true,


Right now the wallet will crash if spark wallet fails to initialize. Instead of setting offline if get balance fails, would it be better to make it so that the wallet doesn't crash if initialization fails, and instead sets offline?

Maybe we should do both.

Btw, sometimes if the Spark infrastructure is having problems while we are in the middle of a receive the SDK will throw and crash the app. It seems like the internal logic of the SDK is throwing when it tries to claim the transfer, but I don't remember exactly

app/features/wallet/use-track-wallet-changes.ts

gudnuf · 2025-11-27T00:42:07Z

bun.lock

I just looked at this lockfile and saw how much crap was added. Bundlephobia gives an install error for this package, so I asked claude to do some digging.

TLDR; "Spark SDK adds roughly 5.4 MB raw / 3.0 MB gzipped to your client bundle - nearly a 4x increase"

Here's the full convo with some tables comparing with and without spark. The last question I asked output a breakdown of the different packages.

I'm just bringing this up because its very large, but I'm not sure there's anything we can really do. Claude says it pulls in 300-500 kB of node dependencies that are irrelevant for the browser. I think the best we can do is complain to the spark team

TLDR; "Spark SDK adds roughly 5.4 MB raw / 3.0 MB gzipped to your client bundle - nearly a 4x increase"

That's a lot. Did you try doing a prod build before and after adding it to confirm the num? We should do that before contacting Spark

Yea this analysis was from doing bun run build before and after adding it

lets also analyse what this means for the app load on slower (3g and 4g) network. If the difference in load time is not huge I guess we can just ignore it for now

I did this by emptying the cache and hard reloading then looking at the "Finish time" in the network tab on Brave

Network Speed Without Spark (ms) With Spark (ms) Spark Bundle Load Time (ms)

3G 57,000 100,000 65,000

Slow 4G 20,000 30,000 18,000

Fast 4G 6,000 7,690 3,600

No Throttling 1,700 2,500 37

what is Spark Bundle Load Time?

You can do this better with Chrome's lighthouse performance analysis (Chrome dev tools -> Lighthouse tab). There you can see how long does it actually take to load the page, for page to become interactive etc. These are better metrics then just checking the network time because there could be some slow paths in the code that is being executed as well.

what is Spark Bundle Load Time?

The time I observed in the network tab for what I saw of the Spark SDK being downloaded. I see two things on load, one is a spark index.js file and the other is like http://localhost:3000/assets/spark-{some-hash}.js

You can do this better with Chrome's lighthouse performance analysis

Lighthouse says it takes too long without spark on fast 4G and won't give me the full results, so here's with the lighthouse default "Simulated throttling":

Without Spark

With Spark

gudnuf · 2025-11-27T00:44:46Z

How should we handle the Spark network? I wrote in the doc that we would have an environment variable, but then decided to define the network on the Spark account. If we will always assume mainnet for production then maybe we don't need to put the network on the account record and can just rely on an environment variable to toggle for development

Putting it on the account would allow us to have different accounts for different networks. How likely that is?

Seems unlikely to me unless Spark started doing stuff on other chains (ie. solana mainnet), but hopefully we wouldn't need to use that even if they did. Otherwise the only reason I see for not using mainnet is testing/dev

app/features/receive/lightning-address-service.tsx

jbojcic1 · 2025-11-27T14:45:18Z

balance doesn't get updated for me. I send 2 sats from Strike and it worked. I got the toast success message but balance was never udpated. Had to reload the app

jbojcic1 · 2025-11-27T14:45:52Z

How should we handle the Spark network? I wrote in the doc that we would have an environment variable, but then decided to define the network on the Spark account. If we will always assume mainnet for production then maybe we don't need to put the network on the account record and can just rely on an environment variable to toggle for development

Putting it on the account would allow us to have different accounts for different networks. How likely that is?

Seems unlikely to me unless Spark started doing stuff on other chains (ie. solana mainnet), but hopefully we wouldn't need to use that even if they did. Otherwise the only reason I see for not using mainnet is testing/dev

lets just keep it as is

jbojcic1 · 2025-11-28T11:33:12Z

I rebased it on top of master to resolve conflicts.

gudnuf · 2025-12-01T00:32:37Z

How should we handle the Spark network? I wrote in the doc that we would have an environment variable, but then decided to define the network on the Spark account. If we will always assume mainnet for production then maybe we don't need to put the network on the account record and can just rely on an environment variable to toggle for development

Putting it on the account would allow us to have different accounts for different networks. How likely that is?

Seems unlikely to me unless Spark started doing stuff on other chains (ie. solana mainnet), but hopefully we wouldn't need to use that even if they did. Otherwise the only reason I see for not using mainnet is testing/dev

lets just keep it as is

If we just keep it as is, then does that mean that we need to create the account before initializing the spark wallet? If we always use mainnet, then we can initialize spark wallet along with the user's keys because all that is needed is the seed from open secret.

supabase/migrations/20251125205840_add-spark-and-allow-one-account.sql

app/routes/_protected.receive.spark.$requestId.tsx

supabase/migrations/20251125205840_add-spark-and-allow-one-account.sql

jbojcic1 · 2025-12-01T12:36:23Z

bun.lock

lets also analyse what this means for the app load on slower (3g and 4g) network. If the difference in load time is not huge I guess we can just ignore it for now

app/features/receive/lightning-address-service.tsx

app/features/settings/accounts/$accountId.tsx

app/features/receive/lightning-address-service.tsx

app/routes/api.lnurlp.verify.$accountId.$requestId.ts

app/features/receive/lightning-address-service.tsx

app/features/receive/spark-lightning-receive-hooks.ts

app/features/settings/accounts/$accountId.tsx

app/features/user/user.ts

gudnuf · 2025-12-04T21:44:50Z

app/lib/spark.ts

+export async function getSparkIdentityPublicKeyFromMnemonic(
+  mnemonic: string,
+  network: NetworkType,
+  accountNumber?: number,


Would it be better to make this function not take the network and instead require the accountNumber to be provided? The reason I did it this way is because the spark sdk is not very transparent on which account numbers are used, but it might be better to create a new getDefaultAccountNumberForNetwork helper that needs to be called first then pass that account number to this function?

So I'd change the signature to :

async function getSparkIdentityPublicKeyFromMnemonic( mnemonic: string, accountNumber: number, ): Promise<string>

seems fine as is

jbojcic1 · 2025-12-04T22:02:14Z

app/features/accounts/balance-offline-hover-card.tsx

+  const cardContent =
+    accountType === 'spark'
+      ? 'Spark is offline. Your balance will be shown when you are online again.'
+      : 'Account is offline. Your balance will be shown when you are online again.';


don't we show cashu balance even if offline?

Yea. I just liked this so that the parent component doesn't need to check the account type. Do you have a suggestion to do it differently? We could call this SparkBalanceOfflineHoverCard and then check the account type whenever its used. Or maybe we don't even need to check because only spark balance will be null, but that seems too implicit.

jbojcic1 · 2025-12-04T22:11:38Z

app/lib/spark.ts

+export async function getSparkIdentityPublicKeyFromMnemonic(
+  mnemonic: string,
+  network: NetworkType,
+  accountNumber?: number,


seems fine as is

gudnuf self-assigned this Nov 5, 2025

gudnuf added enhancement New feature or request P1 High labels Nov 5, 2025

gudnuf requested a review from jbojcic1 November 5, 2025 22:51

This was referenced Nov 5, 2025

Spark #697

Closed

spark lightning sends #700

Merged

gudnuf force-pushed the introduce-spark-accounts branch from 4c7939c to e89e243 Compare November 26, 2025 00:58

vercel bot deployed to Preview November 26, 2025 00:59 View deployment

jbojcic1 reviewed Nov 26, 2025

View reviewed changes

gudnuf commented Nov 27, 2025

View reviewed changes

jbojcic1 reviewed Nov 27, 2025

View reviewed changes

app/features/receive/lightning-address-service.tsx Show resolved Hide resolved

jbojcic1 reviewed Nov 27, 2025

View reviewed changes

app/features/receive/lightning-address-service.tsx Outdated Show resolved Hide resolved

jbojcic1 reviewed Nov 27, 2025

View reviewed changes

app/features/receive/lightning-address-service.tsx Show resolved Hide resolved

jbojcic1 reviewed Nov 27, 2025

View reviewed changes

app/features/receive/lightning-address-service.tsx Outdated Show resolved Hide resolved

jbojcic1 force-pushed the introduce-spark-accounts branch from e89e243 to c2e84c9 Compare November 28, 2025 11:32

vercel bot deployed to Preview November 28, 2025 11:33 View deployment

vercel bot deployed to Preview December 1, 2025 00:24 View deployment

jbojcic1 reviewed Dec 1, 2025

View reviewed changes

vercel bot deployed to Preview December 1, 2025 22:23 View deployment

jbojcic1 reviewed Dec 2, 2025

View reviewed changes

app/features/receive/lightning-address-service.tsx Show resolved Hide resolved

vercel bot deployed to Preview December 2, 2025 22:25 View deployment

jbojcic1 reviewed Dec 3, 2025

View reviewed changes

app/features/receive/spark-lightning-receive-hooks.ts Show resolved Hide resolved

gudnuf added 17 commits December 4, 2025 12:21

introduce spark accounts and allow only 1 btc account

f8f4ab1

introduce spark accounts and allow only 1 btc account

2f6cde9

add spark lightning receives

80a59da

add spark to LNURL server

a73a964

lnurl query client updates

a37331a

move show currenccy selector out of component

30e4489

feedback nits

8e9b0a7

change migration to match our style

d036a6a

lnurl: one verify api, errors, and query client nit

d0392a6

refactor SingleAccount and rename file

c886298

make default account ids deferrable

cded054

bug fixes

8e6de05

change how spark is intitialized

33a6c47

make requestId optional

0b87149

handle spark offline

0ece3e6

remove getServerQueryClient

b36df77

multiple spark accounts and cleanup

b797a36

gudnuf force-pushed the introduce-spark-accounts branch from e947255 to b797a36 Compare December 4, 2025 21:23

vercel bot deployed to Preview December 4, 2025 21:24 View deployment

docs and naming nits

ff865d0

gudnuf commented Dec 4, 2025

View reviewed changes

gudnuf marked this pull request as ready for review December 4, 2025 21:48

vercel bot deployed to Preview December 4, 2025 21:49 View deployment

jbojcic1 reviewed Dec 4, 2025

View reviewed changes

jbojcic1 approved these changes Dec 4, 2025

View reviewed changes

sparkIdentityPublicKey

c88ea19

vercel bot deployed to Preview December 4, 2025 22:55 View deployment

gudnuf merged commit 1080a7c into master Dec 5, 2025
5 checks passed

gudnuf deleted the introduce-spark-accounts branch December 5, 2025 17:15

gudnuf mentioned this pull request Dec 16, 2025

New accounts should be set to default when none exist for that currency #734

Open

Network Speed	Without Spark (ms)	With Spark (ms)	Spark Bundle Load Time (ms)
3G	57,000	100,000	65,000
Slow 4G	20,000	30,000	18,000
Fast 4G	6,000	7,690	3,600
No Throttling	1,700	2,500	37

Conversation

gudnuf commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I've Done

What to do

Questions

Uh oh!

vercel bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbojcic1 commented Nov 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbojcic1 Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Without Spark

With Spark

Uh oh!

gudnuf commented Nov 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbojcic1 commented Nov 27, 2025

Uh oh!

jbojcic1 commented Nov 27, 2025

Uh oh!

jbojcic1 commented Nov 28, 2025

Uh oh!

gudnuf commented Dec 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gudnuf commented Nov 5, 2025 •

edited

Loading

vercel bot commented Nov 5, 2025 •

edited

Loading

supabase bot commented Nov 5, 2025 •

edited

Loading

jbojcic1 Nov 27, 2025 •

edited

Loading