Altium empty comments

[andreyplus]

Added support for Altium empty comments (G04*)

G04*
G04 #@! TF.GenerationSoftware,Altium Limited,Altium Designer,25.8.1 (18)*
G04*

Many G-code variants generated by Altium are not currently supported; significant improvements are required in the future.

[nicolube]

@andreyplus can u pls open issues what exactly is not supported?

[hydra]

@nicolube The missing space between the G04 and the *. With reference to 4.1 Comment (G04) in the 2024.05 spec.

[nicolube]

@andreyplus This is for u...
@hydra This is not my PR

[hydra]

1. I don't think we need a specific test for altium, since that adds quite a lot of code. I feel a simple comment in the test for the scenario might be better.

Please combine the G04* test into G04_comment_attributes and add a rust comment and note that altium doesn't follow the 4.1 Comment (G04) in the 2024.05 spec. (as I understand it).

2. There is missing a test for the following scenario:

G04 *

Please update the existing comment test G04_comment_attributes so the test shows the expected comment is an empty string.

[hydra]

@andreyplus This is for u... @hydra This is not my PR

yes, I understood that, I was just replying to your question on behalf of @andreyplus 😄

[nicolube]

yes, I understood that, I was just replying to your question on behalf of @andreyplus 😄

I thought he meant, besides G4 there is other stuff then is currently not supportet

[andreyplus]

@nicolube @hydra Done

[hydra]

@hydra Done

Awesome, yeah, much more succinct and maintainable now. Merged!