Roll back to chalk v4 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcampbell
approved these changes
Mar 27, 2025
Member
I think the only 'drawback' would be a bump in the minimum required node version? Probably not a big issue |
tristanmenzel
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #36.
What
This rolls back chalk to v4 as v5 is ESM-only and caused issues as reported by @neilcampbell in #36 (comment).
Notes
There's no technical benefit, but I wonder if we could make @makerx/ts-toolkit ESM only? It's a CLI, so there's no chance of that being an issue when used in a TypeScript project that emits CommonJS.
Thoughts?