Added CSS and HTML for basic Tab component#8
Merged
damianmuti merged 4 commits intomasterfrom Apr 12, 2016
Merged
Conversation
assets/styles/modules/_tabs.scss
Outdated
|
|
||
| .tabs { | ||
| margin: $base-spacing * 2; | ||
| .tab { |
Contributor
There was a problem hiding this comment.
As a good practice, to improve legibility, you should leave a breakline between last property and new indented class definition.
Contributor
Author
There was a problem hiding this comment.
ok, it's the prettify that auto-indents like this, i'll configure it to breakline between last property and new indented class definition.
Contributor
|
👍 |
assets/styles/modules/_tabs.scss
Outdated
| This is an almost JS-free Tab component that takes | ||
| advantage of :target event to display tabs content | ||
|
|
||
| // Usage |
Contributor
There was a problem hiding this comment.
These kind of comments go with 3 slashes
/// Comment
This is for further SassDoc integration :)
Contributor
|
Great job, Fran. This is looking great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic tab component