Add customizable controls to music-player#2
Merged
MakingSpiderSense merged 3 commits intoJun 20, 2025
Conversation
…ustomizable selectors and keys
…ema configuration
…controller and keyboard inputs
There was a problem hiding this comment.
Pull Request Overview
This PR adds customizable controls to the music-player component, enabling users to disable controls and configure specific keys or buttons for pausing and skipping tracks.
- Added new schema properties for control enabling and custom selectors/buttons/keys.
- Refactored event listener setup for controller and keyboard inputs into separate helper functions.
- Simplified string trimming logic for song names.
MakingSpiderSense
deleted the
feature/music-player/add-customizable-controls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to disable controls or set the specific keys or buttons to pause or skip tracks.
https://trello.com/c/fZw56fd9