Add loop controls to music player component#3
Merged
MakingSpiderSense merged 4 commits intoJun 26, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a loopMode option to the music-player component to control how the playlist loops (maintain, shuffle, or disable).
- Introduces
loopModein the component schema with default"maintain". - Stores an
originalPlaylistsnapshot to replay in maintain mode. - Updates
playNextSongto branch onloopMode, handling disable, shuffle, and maintain behaviors (with a console warning for unexpected values).
Comments suppressed due to low confidence (3)
src/components/music-player/music-player.js:15
- Update the component’s documentation (e.g., README or inline docs) to describe the new
loopModeproperty and its possible values so users know how to configure looping behavior.
loopMode: { type: "string", default: "maintain" }, // options: 'maintain', 'shuffle', 'disable'
src/components/music-player/music-player.js:15
- Consider enforcing valid
loopModevalues at the schema level (e.g., using an enum or oneOf) to prevent unexpected modes and reduce the need for fallback warnings.
loopMode: { type: "string", default: "maintain" }, // options: 'maintain', 'shuffle', 'disable'
src/components/music-player/music-player.js:75
- Add unit or integration tests for each
loopMode(maintain,shuffle,disable) to verify that the playlist resets and playback behavior match expectations.
// Handle looping the playlist based on loopMode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
loopModeproperty tomusic-playercomponent with options 'maintain', 'shuffle', and 'disable'.