Fix mixin issue and consolidation refresh components#7
Merged
MakingSpiderSense merged 8 commits intoJul 10, 2025
Merged
Conversation
…odel texture handling
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates model load post-processing into a single component, removes redundant refresh and delay components, and updates related documentation.
- Removed two separate components (
delayed-dynamic-body,refresh-raycaster-on-model-load) and introducedpost-model-load-refreshto handle both raycaster and physics-body refresh. - Added configurable fallback mechanism to force a refresh if models don't load within 5 seconds.
- Updated
holdabledocumentation to recommend usingpost-model-load-refreshfor textured models.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/components/refresh-raycaster-on-model-load/...js | Removed; functionality moved into post-model-load-refresh. |
| src/components/delayed-dynamic-body/...js | Removed; functionality consolidated into new component. |
| src/components/post-model-load-refresh/post-model-load-refresh.js | New component: handles refreshing raycasters and physics bodies, with timeout fallback. |
| src/components/holdable/holdable.js | Documentation updated to recommend using post-model-load-refresh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to improve model loading behavior and refresh mechanisms in the scene. It removes redundant components (
delayed-dynamic-bodyandrefresh-raycaster-on-model-load) and consolidates their functionality into a newpost-model-load-refreshcomponent. There is a mixin issue that caused the refresh to never occur in some cases, which is fixed here. Additionally, documentation updates were made to clarify usage recommendations for models with textures.Component Consolidation and Removal:
delayed-dynamic-bodycomponent: The functionality to add adynamic-bodyattribute after a delay has been deprecated and consolidated into the newpost-model-load-refreshcomponent.refresh-raycaster-on-model-loadcomponent: This component's functionality to refresh raycasters after models load has been integrated into thepost-model-load-refreshcomponent.post-model-load-refreshcomponent: Introduced a new component to handle refreshing raycasters and physics bodies after all models have loaded. This resolves race conditions caused by delayed texture loading. It includes configurable options for refreshing raycasters and physics bodies, and a fallback mechanism to ensure refresh occurs even if models fail to load within 5 seconds.Documentation Updates:
holdablecomponent documentation: Added a recommendation to use thepost-model-load-refreshcomponent for scenes with models and textures to ensure proper raycaster and physics body initialization.https://trello.com/c/vDoesUmp