Update dfuds tree#55
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfac24fa48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #ifdef SDSL_SUPPORT | ||
| #pragma message("SDSL_SUPPORT enabled") | ||
| #include "pixie/rmm_tree_sdsl.h" | ||
| using DFUDSTree = pixie::DFUDSTree<pixie::SdslRmMTree>; |
There was a problem hiding this comment.
Avoid using the incomplete SDSL backend for DFUDS
When the third-party benchmark preset defines SDSL_SUPPORT, this alias instantiates DFUDSTree with SdslRmMTree. DFUDS traversal calls select0 in degree, first_child, and parent, but SdslRmMTree::select0_impl is currently a stub returning npos; for any non-leaf random tree, first_child(root) wraps npos + 1 back to 0 and the DFS loop walks invalid nodes instead of measuring the tree. Keep this benchmark on RmMTree or implement select0 in the SDSL adapter before selecting it here.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 89.22% 89.20% -0.03%
==========================================
Files 17 17
Lines 4556 4556
Branches 828 828
==========================================
- Hits 4065 4064 -1
Misses 284 284
- Partials 207 208 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Import RMMTree as a template parameter
Update tests and benchmarks