Skip to content

Update dfuds tree#55

Merged
Sanya239 merged 12 commits into
mainfrom
dfuds-implementation
Jun 21, 2026
Merged

Update dfuds tree#55
Sanya239 merged 12 commits into
mainfrom
dfuds-implementation

Conversation

@Sanya239

Copy link
Copy Markdown
Collaborator

Import RMMTree as a template parameter
Update tests and benchmarks

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfac24fa48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

#ifdef SDSL_SUPPORT
#pragma message("SDSL_SUPPORT enabled")
#include "pixie/rmm_tree_sdsl.h"
using DFUDSTree = pixie::DFUDSTree<pixie::SdslRmMTree>;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid using the incomplete SDSL backend for DFUDS

When the third-party benchmark preset defines SDSL_SUPPORT, this alias instantiates DFUDSTree with SdslRmMTree. DFUDS traversal calls select0 in degree, first_child, and parent, but SdslRmMTree::select0_impl is currently a stub returning npos; for any non-leaf random tree, first_child(root) wraps npos + 1 back to 0 and the DFS loop walks invalid nodes instead of measuring the tree. Keep this benchmark on RmMTree or implement select0 in the SDSL adapter before selecting it here.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.20%. Comparing base (7445639) to head (cfac24f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tests/dfuds_tree_tests.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   89.22%   89.20%   -0.03%     
==========================================
  Files          17       17              
  Lines        4556     4556              
  Branches      828      828              
==========================================
- Hits         4065     4064       -1     
  Misses        284      284              
- Partials      207      208       +1     
Flag Coverage Δ
gcov 89.20% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Sanya239 Sanya239 merged commit 3fae9aa into main Jun 21, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants