Fix PM2.5 correction float divisions#185
Merged
Merged
Conversation
petermnt
force-pushed
the
fix-pm25-float-divisions
branch
from
69aa9c8 to
03e313e
Compare
Owner
|
Thank you for looking into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PM2.5 correction lambda was doing integer division in a couple of places (e.g., 3/2 and 21/5), which silently truncates and slightly skews the correction math. I changed those divisions to explicit floats (3.0/2.0, 21.0/5.0) so the calculations use proper fractional values. This fixes the correction curve without changing any other behavior.