Skip to content

Rails 7.1 support #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Rails 7.1 support #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34873a9
Arel::Table changes in rails 7.1
jrafanie Oct 7, 2024
978de6e
Master supports rails 7.1, drop ruby 2.7-3.0, add 3.2-3.4
jrafanie Feb 17, 2025
defbba0
Use a public API to set the table alias
jrafanie Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ jobs:
strategy:
matrix:
ruby-version:
- '2.7'
- '3.0'
- '3.1'
- '3.2'
- '3.3'
- '3.4'
services:
postgres:
image: postgres:13
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

gem "activerecord", "~>7.0.8"
gem "activerecord", "~>7.1.5"
gem "mysql2"
gem "pg"
gem "sqlite3", "< 2"
Expand Down
6 changes: 2 additions & 4 deletions lib/active_record/virtual_attributes/virtual_delegates.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,9 @@ def self.select_from_alias(to_ref, col, to_model_col_name, src_model_id)
def self.select_from_alias_table(to_klass, src_relation)
to_table = to_klass.arel_table
# if a self join, alias the second table to a different name
if to_table.table_name == src_relation.table_name
# use a dup to not modify the primary table in the model
to_table = to_table.dup
if to_table.name == src_relation.name
# use a table alias to not conflict with table name in the primary query
to_table.table_alias = "#{to_table.table_name}_sub"
to_table = to_table.alias("#{to_table.name}_sub")
end
to_table
end
Expand Down