Use --xlog-method=stream for pg_basebackup#12
Merged
bdunne merged 1 commit intoManageIQ:masterfrom Aug 15, 2018
Merged
Conversation
Previously we were using the "fetch" method which would fail if we did not set wal_keep_segments to a high enough value. We were never setting a value for wal_keep_segments so this would (infrequently) fail. https://bugzilla.redhat.com/show_bug.cgi?id=1616022
Member
Author
|
See also ManageIQ/manageiq-gems-pending#364 for the appliance version of this PR |
carbonin
added a commit
to carbonin/container-postgresql
that referenced
this pull request
Aug 28, 2018
bdunne
added a commit
that referenced
this pull request
Aug 28, 2018
Revert #12 and use --xlog-method=fetch for backups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were using the "fetch" method which would fail if
we did not set wal_keep_segments to a high enough value. We were
never setting a value for wal_keep_segments so this would (infrequently)
fail.
https://bugzilla.redhat.com/show_bug.cgi?id=1616022