Skip to content

Conversation

movitto
Copy link
Contributor

@movitto movitto commented Aug 7, 2013

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 07f5b0b on movitto:lvm2 into aeba1f0 on ManageIQ:master.

@jrafanie
Copy link
Member

jrafanie commented Aug 8, 2013

@movitto travis failed...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling a438bff on movitto:lvm2 into 214a622 on ManageIQ:master.

@movitto
Copy link
Contributor Author

movitto commented Aug 8, 2013

@jrafanie fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@movitto I know the parentheses are not required but I think it reads better to have them here. It's personal preference so it's up to you. Eventually @Fryguy will do a style guide that we can comment on and get everyone on board with trying to have a consistent style.

@jrafanie
Copy link
Member

jrafanie commented Aug 8, 2013

@movitto Looks good other than the minor things I commented on.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 1f3e178 on movitto:lvm2 into 214a622 on ManageIQ:master.

@movitto
Copy link
Contributor Author

movitto commented Aug 12, 2013

@jrafanie updated

jrafanie added a commit that referenced this pull request Aug 12, 2013
flush out lvm write support
@jrafanie jrafanie merged commit 13d37ae into ManageIQ:master Aug 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants