Skip to content

Conversation

jrafanie
Copy link
Member

Fixes #39

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 009e003 on jrafanie:disable_parted_prompts into 8dbd565 on ManageIQ:master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be made a constant, otherwise this method recreates the array every time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fryguy Yeah, that's what I did at first too until I noticed all the callers to parted passed path. path is an attribute set in initialize, so I'm not sure how best to change that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you're right.

Fryguy added a commit that referenced this pull request Aug 24, 2013
Prepend --script to disable all parted prompts.
@Fryguy Fryguy merged commit 6c49753 into ManageIQ:master Aug 24, 2013
@jrafanie jrafanie deleted the disable_parted_prompts branch August 24, 2013 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parted commands should be passed -s option to prevent prompting

3 participants