Support newer ruby versions #1300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a spec demonstrating the failure. Also PR title. |
Ruby changed the way they report backtraces ```diff - app/controllers/api/base_controller/logger.rb:61:in `Api::BaseController::Logger#api_get_method_name' + app/controllers/api/base_controller/logger.rb:61:in 'Api::BaseController::Logger#api_get_method_name' ``` The code was no longer able to determine the method name in recent ruby versions. This meant that it would use the method (symbol) and `Symbol#sub` doesn't work. So we did 2 things: - match backtraces for older rubies and newer versions. - Convert `method` to a String so `String#sub` will work. Reproducer ========== ``` curl -k -u admin:smartvm --basic http://localhost:3000/api/service_catalogs ``` Before ====== ``` Causes: NoMethodError (undefined method 'sub' for an instance of Symbol) app/controllers/api/base_controller/logger.rb:61:in 'Api::BaseController::Logger#api_get_method_name' ``` fixup! fix logger issues
kbrock
changed the title
kbrock
changed the title
kbrock
changed the title
|
update:
|
|
ugh. please see #1302 - identical but I pushed a branch incorrectly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why my system decided it was a good idea to run under ruby 3.4...
Ruby changed the way they report backtraces
The code was no longer able to determine the method name in recent ruby versions.
This meant that it would use the method (symbol) and
Symbol#subdoesn't work.So we did 2 things:
methodto a String soString#subwill work.Reproducer
(pretty much every request test fails along with every api request)
Before
After
other test failures (since string concatenation changed across ruby versions)
But at least the app seems to work.