Service retirement should use make retire as a request #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
Contributor
Author
|
@miq-bot add_label bug, blocker |
Member
|
Checked commit https://github.com/d-m-u/manageiq-ui-service/commit/0de7e2f06a7228630f2a0d94488cd4a184cdaf88 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Contributor
Author
|
I can't get this to fail locally, so that's cool. 🎉 |
d-m-u
changed the title
Member
|
@d-m-u don't sweat it, travis loves to play games with our hearts, (well its not travis.. but.. its an easy blame so 🤷♂️ ) So can this be unwipped, ready for review? |
Contributor
Author
|
@miq-bot remove_label wip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the API call for service retirement changed in ManageIQ/manageiq-api#380 for the new retire as a request, the SUI ought to use the new call.
For https://bugzilla.redhat.com/show_bug.cgi?id=1599299