Squash tooltips from child elements in toolbar dropdown if disabled

[skateman]

When there's a toolbar dropdown with all child items disabled, it is not possible to open it. Each disabled toolbar button contains a hint about why it is disabled if you hover on it. These two things don't really fit together as you are not able to hover onto a disabled child element in a dropdown if all the other child elements are disabled.

My solution is to, if it is necessary, collect all the tooltips from the child items and display them inside the tooltip of the parent element.

@miq-bot add_reviewer @karelhala
@miq-bot add_reviewer @Hyperkid123
@miq-bot add_label toolbars, hammer/no, ux/review

Fixes ManageIQ/manageiq#18460

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1699322

[miq-bot]

@skateman Cannot apply the following label because they are not recognized: toolbars

[terezanovotna]

⚬ or-should work

we want to show what is the title and what is the explanation

[skateman]

@terezanovotna so you're saying:

Parent button tooltip
⚬child button title - child button tooltip
⚬child button title - child button tooltip
...

Like this?

[terezanovotna]

How about this?

Title

Subtitle --- Lorem Ipsum is simply dummy text
of the printing and typesetting industry. Lorem Ipsum
has been the industry's standard dummy text ever s
ince the 1500s,

Subtitle --- Lorem Ipsum is simply dummy text
of the printing and typesetting industry. Lorem Ipsum
has been the industry's standard dummy text ever s
ince the 1500s,

[skateman]

@terezanovotna here are some examples that I tried:
Bullets - one dash - single newline

Dashes - one dash - single newline

Nothing - one dash - single newline

Nothing - one dash - double newline

Nothing - three dashes - double newline

I can vary some of these combos if you want to see them, just let me know which one 😉

[terezanovotna]

this is my winner.

Bullets - one dash - single newline

Thank you!

[skateman]

@karelhala travis issues seem irrelephant to me

[Hyperkid123]

Looks gut. And Travis is complains about dialog something else.

[skateman]

Travis fix is here #374
@terezanovotna can I get your approval label? 😉

[skateman]

@martinpovolny it's already implemented and I think you meat React and not Angular 😉
Anyway, @terezanovotna is on PTO, but as she chose the right solution, I think it can be taken as an approval and it is okay to merge.

[himdel]

Looks like this is also trying to add the * undefined - undefined for separators.

[miq-bot]

Checked commit skateman@ab4887d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

[himdel]

LGTM, now only seeing the non-empty items :)

[terezanovotna]

@miq-bot remove_label ux/review
@miq-bot add_label ux/approved

[skateman]

@miq-bot rm_label hammer/no
@miq-bot add_label hammer/yes

[martinpovolny]

https://bugzilla.redhat.com/show_bug.cgi?id=1699322

[simaishi]

Hammer backport details:

$ git log -1
commit a5a8143d02b5ece5b71bfab9b80f1dc4b58a212f
Author: Martin Hradil <himdel@seznam.cz>
Date:   Tue Mar 19 13:03:37 2019 +0000

    Merge pull request #372 from skateman/toolbar-dropdown-disabled
    
    Squash tooltips from child elements in toolbar dropdown if disabled
    
    (cherry picked from commit 348f2620c39582a514e600cf53d55908d409302e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1705141