Skip to content

Conversation

@skateman
Copy link
Member

Any better ideas are welcome ...
@karelhala @martinpovolny @Hyperkid123

@Hyperkid123
Copy link
Contributor

Seems good enough but i have no clue what is this component and what is used for.

@himdel
Copy link
Contributor

himdel commented Mar 18, 2019

LGTM too :).

(Though the validation problem can probably be fixed by using if (this.validation) instead of if (_.isObject(this.validation)) {, because typescript interprets if (_.isObject(foo)) as narrowing down the type of foo to be object.)

The TypeError: undefined is not an object (evaluating 'this.$newElement[0].parentNode.classList.contains') in dist/js/vendor.js (line 74571) problem is present even after #364 switching from phantomjs to jsdom, investigating..

@himdel
Copy link
Contributor

himdel commented Mar 18, 2019

The failure is caused by using the wrong version of bootstrap-select - #375

@skateman skateman changed the title Fix failing Travis on dialogField by adding the Validation interface Fix linter issues in specs Mar 18, 2019
@miq-bot
Copy link
Member

miq-bot commented Mar 18, 2019

Checked commit skateman@c8acaf5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@skateman skateman closed this Mar 19, 2019
@skateman skateman reopened this Mar 19, 2019
@himdel himdel self-assigned this Mar 19, 2019
@himdel himdel added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 19, 2019
@himdel himdel merged commit aaa1ade into ManageIQ:master Mar 19, 2019
@skateman skateman deleted the fix-build-ts branch March 19, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants