Skip to content

subnet changed#21

Merged
Vasanth1292 merged 2 commits intomainfrom
Demo-Prisma
Mar 27, 2024
Merged

subnet changed#21
Vasanth1292 merged 2 commits intomainfrom
Demo-Prisma

Conversation

@Vasanth1292
Copy link
Copy Markdown

Subnet changed

Copy link
Copy Markdown

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

service.tf Outdated
resource "aws_subnet" "my_subnet" {
vpc_id = aws_vpc.my_vpc.id
cidr_block = "10.0.1.0/24"
cidr_block = "10.0.2.0/24"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  AWS VPC subnets should not allow automatic public IP assignment
    Resource: aws_subnet.my_subnet | Checkov ID: CKV_AWS_130

How to Fix

resource "aws_subnet" "test" {
 ...
+ map_public_ip_on_launch = false
  }

Description

VPC subnet is a part of the VPC having its own rules for traffic.
Assigning the Public IP to the subnet automatically (on launch) can accidentally expose the instances within this subnet to internet and should be edited to 'No' post creation of the Subnet.

@Vasanth1292 Vasanth1292 merged commit 10170f0 into main Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant