fix fast_fn property inheritance by using PrototypeTemplate#8
Merged
MangelSpec merged 1 commit intomasterfrom Feb 13, 2026
Merged
fix fast_fn property inheritance by using PrototypeTemplate#8MangelSpec merged 1 commit intomasterfrom
MangelSpec merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetAccessorProperty on InstanceTemplate doesn't propagate through FunctionTemplate::Inherit(), unlike SetNativeDataProperty. This caused fast_fn properties defined on a base class to return undefined when accessed on derived class instances. Moving to PrototypeTemplate matches how all other class bindings (functions, constants, symbols) work and follows normal JS prototype chain semantics.