fix(gemini): skip enter key interception for default preset#35
Merged
Conversation
The enter-behavior content script was intercepting Enter key events in capture phase even when the default preset was active. Since the default preset (Enter=send, Shift+Enter=newline) matches Gemini's native behavior, intercepting it caused findSendButton() to match wrong UI elements (e.g. sidebar menu buttons), breaking normal message sending. Add early return when preset is 'default' to let Gemini's native Enter key handling work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the Panelize extension is installed, pressing Enter on a standalone Gemini page does not send the message. Instead, it triggers the sidebar chat history menu (Share conversation / Pin / Rename / Delete).
Root Cause
enter-behavior-gemini.jsintercepts Enter key events in the capture phase, callspreventDefault()+stopImmediatePropagation(), and then tries to find and click a send button viafindSendButton(). The button finder uses broad CSS selectors likebutton[aria-label*="Send"], which can match wrong UI elements or fail to find the correct one.The core issue: in default preset mode, the script re-implements Gemini's native behavior (Enter=send, Shift+Enter=newline) but does it worse.
Fix
Add an early return when
enterKeyConfig.preset === 'default'to let Gemini's native Enter key handling work correctly without interception.Testing
multi-panel-ime.test.jsunrelated to this change)