Skip to content

Maze realization and backends#3

Open
seanrivera wants to merge 9 commits into
mainfrom
maze-realization-and-backends
Open

Maze realization and backends#3
seanrivera wants to merge 9 commits into
mainfrom
maze-realization-and-backends

Conversation

@seanrivera
Copy link
Copy Markdown
Member

This is part 2 of the 4 part review requests. Feel free to split them among people as needed. This one is just the Minigrid/Multigrid codebase.

@seanrivera seanrivera requested a review from pranavguru April 25, 2026 21:18
Copy link
Copy Markdown
Member

@pranavguru pranavguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of overall comments:

  • Seems like there are quite a few duplicate, identical files with the #2 branch - this shouldn't be the case. Increases bloat on the PRs
  • Since MultiGrid is not immediate priority and not on the critical path for the first few set of experiments we need to run, the modules related to MultiGrid can be reviewed later

@pranavguru pranavguru self-requested a review May 1, 2026 03:59
@seanrivera seanrivera force-pushed the maze-realization-and-backends branch from 79f72a5 to 55e6ada Compare May 1, 2026 22:08
@pranavguru
Copy link
Copy Markdown
Member

The duplicate files issue hasn't been addressed yet right? @seanrivera

@seanrivera seanrivera force-pushed the maze-realization-and-backends branch from 55e6ada to 3e36ee7 Compare May 9, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants