Fix #125 by adding custom .interpolate method for ValueTracker #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused `.become_partial` method from Mobject Fixes #125
Aathish04
changed the title
.interpolate method for ValueTracker
leotrs
approved these changes
Jun 3, 2020
Contributor
|
This LGTM - but could you please leave an explanation here as to how this resolves #125? If only for the record :) |
Member
Author
Done :) |
TonyCrane
approved these changes
Jun 3, 2020
kilacoda
approved these changes
Jun 3, 2020
Contributor
|
Damnit approved by wrong account. |
kilacoda-old
approved these changes
Jun 3, 2020
Contributor
|
that's better |
PgBiel
reviewed
Jun 3, 2020
Comment on lines
+32
to
+35
| """ | ||
| Turns self into an interpolation between mobject1 | ||
| and mobject2. | ||
| """ |
Member
There was a problem hiding this comment.
I was going to comment about documentation guidelines, but I guess we can just copy the interpolate docs from when we finish them from Mobject into this, so should be ok
PgBiel
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom .interpolate method for ValueTracker
Removed unused .become_partial method from Mobject
Removed Trailing Spaces from ValueTracker and Mobject.
Fixes #125
Commit 62050bb had changed the pass statements of some of the methods of Mobject() into NotImplementedError s.
The method interpolate_color was one such method.
ThreeDCamera uses ValueTracker Mobjects in order to store the positions of the camera.
When ThreeDScene.move_camera() is called, the interpolate mobject of the ValueTracker is called.
This method then calls interpolate_color, and since ValueTracker does not have a custom interpolate_color method, it uses the one in Mobject which it inherits from.
The interpolate_color method of Mobject only raises a NotImplementedError, and this results in ThreeDScene.move_camera() failing.
This PR adds a custom interpolate method for ValueTracker, as suggested by @tony031218. This custom method does not call interpolate_color and hence fixes the issue.
Also, the .become_partial method was not mentioned anywhere outside of its definition, which itself simply raised a NotImplementedError, and hence was removed.