Skip to content

Conversation

@jakekinchen
Copy link
Contributor

Summary

  • Prevent DashedVMobject from duplicating tips: copy the input, pop tips once, build dashes from the tipless copy, then reattach the original tips a single time.
  • Keeps opacity consistent when groups set fill/stroke with family=True; works with default and custom tip shapes and with start+end tips.
  • Adds regression tests covering dashed arrows (default, custom tip, start+end tip) and group opacity to guard against stacked tips.

Testing

  • uv run pytest tests/module/mobject/types/vectorized_mobject/test_dashed_vmobject.py -q
  • uv run pytest

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution, this looks fine to me!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Nov 27, 2025
@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Nov 27, 2025
@behackl behackl enabled auto-merge (squash) November 27, 2025 09:37
@behackl behackl merged commit 51aa01a into ManimCommunity:main Nov 27, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants