Cleanup TipableVMobject: avoid mutable default and fix assign_tip_attr typo#4503
Merged
behackl merged 4 commits intoManimCommunity:mainfrom Feb 22, 2026
Merged
Conversation
- fixed mutable default argument in Tipable VMobject constructor - fixed typo in method name assign_tip_attr - added two todo's which outline unexpected behavior in tip placement and how to solve
behackl
requested changes
Jan 19, 2026
Member
behackl
left a comment
There was a problem hiding this comment.
Hi, thanks for your contribution! Two things:
- the renamed method for fixing the typo, there is another one in
opengl_geometry.py-- please update it there as well, - and instead of adding TODOs in comments to the code base, please open a corresponding issue instead!
Other than that, this seems good to go from my side. Thanks again!
Member
|
I picked this up and addressed the outstanding review points:
This branch now contains the changes. |
behackl
approved these changes
Feb 22, 2026
Member
behackl
left a comment
There was a problem hiding this comment.
Merging this once tests pass.
TipableVMobject: avoid mutable default and fix assign_tip_attr typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
tip_styleparameter in TipableVMobject constructor now defaults toNoneinstead of a mutable dictTipableVMobject.assign_tip_attrmethod nameTODOs to outline my plan to fix some issues with how TipableVMobject adds new tipsMotivation and Explanation: Why and how do your changes improve the library?
Just a few touch ups I thought I'd make a pull request for:
TipableVMobjectconstructor'stip_styleparameter had a mutable default argument (see here for why this is likely not what the original author of this constructor intended)Noneas default argument instead, and default the attribute to an empty dict if givenNoneTipableVMobject.asign_tip_attrhas a typo in the method name. Seems to only be used in one place so it's an easy fixTipableVMobjectclass isn't broken, these issues cause hiccups and unexpected behavior when developing new tip shapes.Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist