Fix creation or animation of a zero-length DashedLine#4606
Merged
behackl merged 2 commits intoManimCommunity:mainfrom Feb 22, 2026
Merged
Fix creation or animation of a zero-length DashedLine#4606behackl merged 2 commits intoManimCommunity:mainfrom
DashedLine#4606behackl merged 2 commits intoManimCommunity:mainfrom
Conversation
SORVER
changed the title
for more information, see https://pre-commit.ci
behackl
changed the title
DashedLine
behackl
approved these changes
Feb 22, 2026
Member
behackl
left a comment
behackl
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution! LGTM.
Contributor
Author
|
@behackl , You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix crash when creating or animating a zero-length
DashedLine(start == end).Issue: #4591
Motivation
DashedLine(ORIGIN, ORIGIN)or converting a line to zero-length causedIndexErrorbecausepop_tips()always calledput_start_and_end_on, breaking the points array.Fix: Only call
put_start_and_end_onwhen tips are actually removed.Changed Files
manim/mobject/geometry/arc.py– guard added inpop_tips()tests/module/mobject/types/vectorized_mobject/test_dashed_vmobject.py– added regression testsChecklist