Fix unintended propagation of kwargs in LaggedStartMap#4613
Merged
behackl merged 6 commits intoManimCommunity:mainfrom Feb 27, 2026
Merged
Fix unintended propagation of kwargs in LaggedStartMap#4613behackl merged 6 commits intoManimCommunity:mainfrom
kwargs in LaggedStartMap#4613behackl merged 6 commits intoManimCommunity:mainfrom
Conversation
Ensure intended for are not forwarded to the superclass, and make explicit.
behackl
approved these changes
Feb 26, 2026
Member
behackl
left a comment
There was a problem hiding this comment.
This seems reasonable to me, thanks for the fix!
Do you think it makes sense to add some kind of explicit test for this?
Member
|
Proposed one test in a reviewer commit. After writing/reading this again, it does feel a bit odd to read Is this fine? Should we improve it in a different way? |
Contributor
Author
|
@behackl Thanks for reviewing. I have updated the test. |
behackl
approved these changes
Feb 27, 2026
kwargs propagation in LaggedStartMapkwargs in LaggedStartMap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fix #4508
Motivation and Explanation: Why and how do your changes improve the library?
Fix unintended
kwargspropagation inLaggedStartMapEnsure
kwargsintended specifically foranimation_classare not forwarded to the superclasses ofLaggedStartMap, and makelag_ratioexplicit."