Skip to content

Fix unintended propagation of kwargs in LaggedStartMap#4613

Merged
behackl merged 6 commits intoManimCommunity:mainfrom
irvanalhaq9:fix-laggedstartmap
Feb 27, 2026
Merged

Fix unintended propagation of kwargs in LaggedStartMap#4613
behackl merged 6 commits intoManimCommunity:mainfrom
irvanalhaq9:fix-laggedstartmap

Conversation

@irvanalhaq9
Copy link
Contributor

@irvanalhaq9 irvanalhaq9 commented Feb 26, 2026

Overview: What does this pull request change?

Fix #4508

Motivation and Explanation: Why and how do your changes improve the library?

Fix unintended kwargs propagation in LaggedStartMap
Ensure kwargs intended specifically for animation_class are not forwarded to the superclasses of LaggedStartMap, and make lag_ratio explicit."

Ensure  intended for  are not forwarded to the superclass, and make  explicit.
@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Feb 26, 2026
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thanks for the fix!

Do you think it makes sense to add some kind of explicit test for this?

@behackl
Copy link
Member

behackl commented Feb 27, 2026

Proposed one test in a reviewer commit. After writing/reading this again, it does feel a bit odd to read

anim = LaggedStartMap(..., rate_func=linear)
assert anim.rate_func is smooth

Is this fine? Should we improve it in a different way?

@irvanalhaq9
Copy link
Contributor Author

@behackl Thanks for reviewing. I have updated the test.

@behackl behackl merged commit 6f825e8 into ManimCommunity:main Feb 27, 2026
15 checks passed
@behackl behackl changed the title Fix unintended kwargs propagation in LaggedStartMap Fix unintended propagation of kwargs in LaggedStartMap Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LaggedStartMap new bug (since 0.19.1)

2 participants