Fix IndexError in get_nth_subpath() and ensure it always returns a NumPy array#4630
Merged
Conversation
chopan050
changed the title
IndexError in get_nth_subpath() and ensure it always returns a NumPy array
chopan050
approved these changes
Mar 18, 2026
Member
chopan050
left a comment
chopan050
left a comment
There was a problem hiding this comment.
LGTM! Thanks for these fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes #3569 by making sure that
get_nth_subpath()always returns a NumPy arrayFixes #4629 by falling back to a null curve at
ORIGINin the case thatpath_listis empty, preventing anIndexError.Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist