Refactor ContextMenu API and usages (breaking API change) #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the context menu system by extracting the MenuEntry struct into a separate ContextMenuEntry class and updating the API to support MemberInfo parameters. The refactoring distributes context menu registration across individual feature classes rather than centralizing it in the ContextMenu class.
Key changes:
- Extracted
MenuEntryto a newContextMenuEntryclass with updated API signature - Moved context menu entry registration from centralized initialization to individual feature classes
- Changed
MenuContentsfrom instance to static property for easier access across features
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| RuntimeUnityEditor.Core/Features/ContextMenuEntry.cs | New file defining the extracted ContextMenuEntry struct with MemberInfo support |
| RuntimeUnityEditor.Core/Features/ContextMenu.cs | Refactored to use new ContextMenuEntry, removed MenuEntry definition and centralized menu registration |
| RuntimeUnityEditor.Core/Windows/REPL/REPLWindow.cs | Added "Send to REPL" context menu entry registration |
| RuntimeUnityEditor.Core/Windows/ObjectView/ObjectViewWindow.cs | Added preview and event details context menu entry registrations |
| RuntimeUnityEditor.Core/Windows/ObjectTree/ObjectTreeViewer.cs | Added find in object tree and find references context menu entry registrations |
| RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs | Added "Send to inspector" context menu entry registration |
| RuntimeUnityEditor.Core/Windows/Clipboard/ClipboardWindow.cs | Added copy to clipboard context menu entry registration |
| RuntimeUnityEditor.Core/Windows/Breakpoints/BreakpointsWindow.cs | Moved breakpoint context menu registration from ContextMenu to BreakpointsWindow |
| RuntimeUnityEditor.Core/Utils/Abstractions/DnSpyHelper.cs | Added dnSpy-related context menu entry registrations |
| RuntimeUnityEditor.Bepin5/PatchInspector/PatchInspector.cs | Added harmony patch management context menu entry registrations |
| RuntimeUnityEditor.Core/RuntimeUnityEditor.Core.projitems | Added ContextMenuEntry.cs to project compilation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| MinimumSize = new Vector2(250, 100); | ||
| DefaultScreenPosition = ScreenPartition.LeftUpper; | ||
|
|
||
| ContextMenu.MenuContents.Add(new ContextMenuEntry("Copy to clipboard", null, (o, info, name) => { if (Contents.LastOrDefault() != (o ?? info)) Contents.Add(o ?? info); })); |
There was a problem hiding this comment.
The inline lambda is complex with nested logic (o ?? info used twice) and the condition check. Consider extracting this to a named method for better readability and testability.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ManlyMarco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.