Merged
Conversation
GeorgWa
reviewed
Apr 14, 2026
| process_num = self.mp_process_num | ||
| if device == "mps" and process_num > 1: | ||
| logger.info( | ||
| "Multiprocessing is not supported with MPS device, falling back to single process" |
Collaborator
There was a problem hiding this comment.
I’m not aware of this issue tbh. Do we need this?
Collaborator
Author
There was a problem hiding this comment.
the tests tell us so? but I am also confused
Collaborator
Author
There was a problem hiding this comment.
it was introduced by 5a8920a
reinitialize_ms2_model creates a new pDeepModel() without passing the device — so it defaults to CPU. After the call:
- ms2_model.device_type is "cpu"
- peptdeep's guard self.ms2_model.device_type != "cpu" evaluates to False
- It falls through to the multiprocessing path
- But the other models (RT, CCS) are still on MPS, and share_memory_() fails on those MPS tensors
I patched it here at the two places where reinitialize_ms2_model is called .. but peptdeep should preserve the device I guess ..
Collaborator
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
so can we solve this on the peptdeep level?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests (detected only by the "full matrix"
@GeorgWa not sure why this did not come up earlier? b1a13fa