Substitute setup.py with pyproject.toml#41
Conversation
|
|
||
| [project.urls] | ||
|
|
||
| "Paper" = "https://doi.org/10.1016/j.mcpro.2023.100581" |
There was a problem hiding this comment.
maybe comment our for now ;-)
| optional-dependencies = { stable = { file = ["requirements/requirements.txt", | ||
| ] }, gui = { file = [ "requirements/requirements_gui_loose.txt", | ||
| ] }, gui-stable = { file = [ "requirements/requirements_gui.txt", | ||
| ] }, tests = { file = [ "requirements/requirements_tests.txt", |
There was a problem hiding this comment.
requirements_tests.txt does not exists.. the idea is that this collects all dependencies that are used for testing, e.g. pytest (and that alphaquant[..., tests] is used for testing rather than alphaquant[..., development]) .. currently this is done here run_unittests.sh
either add that file of remove it from here
There was a problem hiding this comment.
👍 overlooked this, added requirements_tests.txt, however, where is it set which environment is used? Should I adapt it in the run_unittests.sh?
There was a problem hiding this comment.
I would suggest to decouple the setting up of the env from the actual running of the test
https://github.com/MannLabs/alphadia/blob/main/.github/workflows/_run_tests.yml#L43-L52
cf. https://github.com/MannLabs/alphadia/blob/main/tests/run_unit_tests.sh
cf. https://github.com/MannLabs/alphadia/blob/main/misc/pip_install.sh and
| @@ -0,0 +1,131 @@ | |||
| """Test that the strict and loose requirements files are aligned.""" | |||
There was a problem hiding this comment.
did you check that this test is run in the CI?
There was a problem hiding this comment.
Hmm I did not see it run in CI in directlfq, I thought the alphashared does that for the release. Would you recommend having a dedicated CI test for this?
There was a problem hiding this comment.
I think it's a matter of pytest discovery,
currently you have in run_tests.sh
cd unit_tests
python -m pytest -v
cd ..
which renders the pytests folder 'invisible' for pytest ..
There was a problem hiding this comment.
could just move test_req..py to unit_tests?
| @@ -16,5 +16,4 @@ openpyxl==3.1.5 | |||
| scikit-learn==1.5.2 | |||
| alphabase==1.4.0 | |||
| matplotlib-venn==1.1.1 | |||
There was a problem hiding this comment.
looks like some of these could go to requirements_gui.txt?
2 participants
in progress