Skip to content

Conversation

@rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Nov 12, 2025

Description

Fixes processing by allowing None values from failed model requests across all tasks.

Related Issues

-

Changes Made

  • Fixes None processing across all tasks.

Checklist

  • [ ] Tests have been extended to cover changes in functionality
  • Existing and new tests succeed
  • Documentation updated (if applicable)
  • Related issues linked

Screenshots/Examples (if applicable)

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sieves/engines/outlines_.py 0.00% 4 Missing ⚠️
sieves/tasks/predictive/ner/bridges.py 50.00% 3 Missing ⚠️
sieves/tasks/predictive/classification/bridges.py 66.66% 1 Missing ⚠️
...ves/tasks/predictive/question_answering/bridges.py 50.00% 1 Missing ⚠️
...ves/tasks/predictive/sentiment_analysis/bridges.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   92.86%   92.65%   -0.21%     
==========================================
  Files          63       63              
  Lines        3321     3336      +15     
==========================================
+ Hits         3084     3091       +7     
- Misses        237      245       +8     
Files with missing lines Coverage Δ
sieves/serialization.py 98.85% <100.00%> (ø)
sieves/tasks/optimization/core.py 92.85% <100.00%> (+0.17%) ⬆️
sieves/tasks/predictive/pii_masking/bridges.py 98.61% <100.00%> (ø)
sieves/tasks/predictive/classification/bridges.py 88.06% <66.66%> (-0.32%) ⬇️
...ves/tasks/predictive/question_answering/bridges.py 99.15% <50.00%> (-0.85%) ⬇️
...ves/tasks/predictive/sentiment_analysis/bridges.py 99.13% <66.66%> (-0.87%) ⬇️
sieves/tasks/predictive/ner/bridges.py 93.60% <50.00%> (-1.08%) ⬇️
sieves/engines/outlines_.py 76.59% <0.00%> (-3.41%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmitsch rmitsch marked this pull request as ready for review November 12, 2025 17:40
@rmitsch rmitsch merged commit ec6dae3 into main Nov 12, 2025
3 checks passed
@rmitsch rmitsch deleted the fix/non-strict-support branch November 12, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant