Skip to content

Conversation

@rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Dec 17, 2025

Description

Renames Engine to ModelWrapper, EngineType to ModelType for better readability and easier to understand architecture.

Related Issues

Changes Made

Checklist

  • [ ] Tests have been extended to cover changes in functionality
  • Existing and new tests succeed
  • Documentation updated (if applicable)
  • Related issues linked

Screenshots/Examples (if applicable)

@rmitsch rmitsch self-assigned this Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 92.77778% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sieves/model_wrappers/model_type.py 91.30% 2 Missing ⚠️
sieves/model_wrappers/huggingface_.py 75.00% 1 Missing ⚠️
sieves/model_wrappers/langchain_.py 66.66% 1 Missing ⚠️
sieves/tasks/predictive/classification/core.py 87.50% 1 Missing ⚠️
sieves/tasks/predictive/core.py 92.85% 1 Missing ⚠️
...es/tasks/predictive/information_extraction/core.py 87.50% 1 Missing ⚠️
sieves/tasks/predictive/ner/core.py 85.71% 1 Missing ⚠️
sieves/tasks/predictive/pii_masking/core.py 85.71% 1 Missing ⚠️
sieves/tasks/predictive/question_answering/core.py 85.71% 1 Missing ⚠️
sieves/tasks/predictive/sentiment_analysis/core.py 85.71% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   92.97%   93.63%   +0.65%     
==========================================
  Files          62       62              
  Lines        3347     3348       +1     
==========================================
+ Hits         3112     3135      +23     
+ Misses        235      213      -22     
Files with missing lines Coverage Δ
sieves/__init__.py 100.00% <100.00%> (ø)
sieves/model_wrappers/__init__.py 100.00% <100.00%> (ø)
sieves/model_wrappers/core.py 96.66% <100.00%> (ø)
sieves/model_wrappers/dspy_.py 85.96% <100.00%> (ø)
sieves/model_wrappers/gliner_.py 94.11% <100.00%> (ø)
sieves/model_wrappers/outlines_.py 80.85% <100.00%> (ø)
sieves/model_wrappers/types.py 100.00% <ø> (ø)
sieves/model_wrappers/utils.py 87.50% <100.00%> (ø)
sieves/tasks/core.py 97.82% <ø> (ø)
sieves/tasks/distillation/types.py 100.00% <ø> (ø)
... and 22 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmitsch rmitsch marked this pull request as ready for review December 17, 2025 21:02
@rmitsch rmitsch merged commit ad61b5e into main Dec 17, 2025
3 checks passed
@rmitsch rmitsch deleted the 224-engine-rename branch December 17, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Engine to ModelWrapper

1 participant