feat: validation for tile pixel size to be 256X256 (MAPCO-3226)#164
Merged
nitzanmorr merged 5 commits intomasterfrom Sep 11, 2024
Merged
feat: validation for tile pixel size to be 256X256 (MAPCO-3226)#164nitzanmorr merged 5 commits intomasterfrom
nitzanmorr merged 5 commits intomasterfrom
Conversation
CL-SHLOMIKONCHA
requested changes
Aug 29, 2024
…side the constructor
shimoncohen
reviewed
Sep 4, 2024
Co-authored-by: Shimon Cohen <33935191+shimoncohen@users.noreply.github.com>
shimoncohen
approved these changes
Sep 5, 2024
CL-SHLOMIKONCHA
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a validation for pixel size every time a tile is generated. If the tile is not 256X256, an error will be thrown.
Suiting unit tests were added and existing tests were modified to use actual images instead of just bytes arrays' so it will work with the new Tile class validation.