docs(elevation API): add response explanation and confidence level definition#72
Merged
shimoncohen merged 4 commits intomasterfrom Jan 4, 2024
Merged
Conversation
Contributor
shimoncohen
commented
Dec 23, 2023
shimoncohen
commented
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✖ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✔ |
| Tests added | ✖ |
| Chore | ✖ |
alebinson
previously approved these changes
Dec 25, 2023
Contributor
alebinson
left a comment
alebinson
left a comment
There was a problem hiding this comment.
Basically approved, but see my comment (feel free to rephrase it)
alebinson
reviewed
Dec 26, 2023
| * `resolutionMeter` - precision on the horizontal plane (may be interpolated), meaning that for every `x` meters there is a value in the mesh | ||
| * `absoluteAccuracyLEP90` - each height measurement has a 90% chance to have a deviation of at most `x` meters from the given value (between `height` - `x` and `height` + `x`) | ||
|
|
||
| It is extremely important to provide all of the information about the product which the height was extracted from, for each point you query, in order to allow the user to make the best decision based on the data. |
Contributor
There was a problem hiding this comment.
GOOD, but think that part "in order to allow the user to make the best decision based on the data" is redundant
Contributor
Author
There was a problem hiding this comment.
Removed, but added an info banner for the required values to be displayed.
syncush
requested changes
Jan 4, 2024
Contributor
syncush
left a comment
syncush
left a comment
There was a problem hiding this comment.
Where is the open api for elevation ?
syncush
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.