Skip to content

feat(dump): added project id to dump metadata url#22

Merged
syncush merged 8 commits into
masterfrom
melancholiai/issue21
Apr 25, 2021
Merged

feat(dump): added project id to dump metadata url#22
syncush merged 8 commits into
masterfrom
melancholiai/issue21

Conversation

@melancholiai

@melancholiai melancholiai commented Apr 13, 2021

Copy link
Copy Markdown
Contributor
Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

Closes #21

@melancholiai melancholiai requested a review from syncush April 13, 2021 10:38

@syncush syncush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be covered with tests

@melancholiai

Copy link
Copy Markdown
Contributor Author

this needs to be covered with tests

it is, my bad for missing a V on the table

@syncush syncush force-pushed the melancholiai/issue21 branch from 189ca71 to a3f7c09 Compare April 21, 2021 10:20
Comment thread src/dumpMetadata/models/dumpMetadataManager.ts Outdated
@syncush syncush force-pushed the melancholiai/issue21 branch from 9cfc618 to a3f7c09 Compare April 21, 2021 17:24
@melancholiai melancholiai force-pushed the melancholiai/issue21 branch from 9cfc618 to 58b8e5b Compare April 22, 2021 08:04
@melancholiai melancholiai force-pushed the melancholiai/issue21 branch from 58b8e5b to aa66c3e Compare April 22, 2021 08:09
@syncush syncush force-pushed the melancholiai/issue21 branch from 71b193c to e772c7b Compare April 22, 2021 13:42
Comment thread src/dumpMetadata/models/dumpMetadataManager.ts
@syncush syncush merged commit 9b3edbc into master Apr 25, 2021
@syncush syncush deleted the melancholiai/issue21 branch April 25, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add project id to dump metadata url

2 participants