0.1.0 by NivGreenstein · Pull Request #14 · MapColonies/geocoding

NivGreenstein · 2024-09-10T07:39:40Z

Question	Answer
Bug fix	✔
New feature	✔
Breaking change	✔
Deprecations	✔
Documentation	✖
Tests added	✔
Chore	✔

This is the implementation of the new architecture of Geocoding API. It includes Control grid search and location search.

… provided

…o query it

…reusable function

…d ELASTIC_KEYWORDS as exported const

…tile query.

…to camelCase interface

…to camelCase CommonRequestParameters infered type

…et_grid-and-version-are-missing-in-geocodingqueryobject-in-the-response-mapco-4784

… is not defined

shimoncohen · 2024-09-16T14:15:26Z

+      "files": {
+        "__name": "S3_FILES_DATA",
+        "__format": "json"
+      }


This is supposed to be a large file, don't we want to provide it in another way?

This is the config and metadata for the files that are being stores in S3.
This way the service knows what bucket and file's name to pull.

shimoncohen · 2024-09-16T14:16:53Z

+        "node": "http://control_elastic:9200",
        "auth": {
-          "username": "control",
-          "password": "password"
+          "username": "elastic",
+          "password": "changeme"


This should stay as default values. These seem to be actual credentials (even if for local work).

elastic and changeme are the default Elasticsearch credentials.
control_elastic is just the placeholder. for local env, you need to change it to localhost if you are running it locally.

shimoncohen · 2024-09-16T14:17:05Z

+        "node": "http://geotext_elastic:9200",
        "auth": {
-          "username": "geotext",
-          "password": "password"
+          "username": "elastic",
+          "password": "changeme"


shimoncohen · 2024-09-16T14:19:46Z

+    "controlObjectDisplayNamePrefixes": {
+      "TILE": "Tile",
+      "SUB_TILE": "Sub Tile",
+      "ROUTE": "Route",
+      "ITEM": "Item",
+      "CONTROL_POINT": "Control Point"
    },


Is this really needed? You could do the same as you do with snake to camel and vice versa and seperate by spaces.

This is a dictionary to the feature's generated display name.
I'll change the config's name to a better name

shimoncohen · 2024-09-16T14:25:40Z

+        "F_CODE": 8754111,
+        "F_ATT": 951111,
+        "ENTITY_HEB": "control point",
+        "LAYER_NAME": "CONTROL_GIL_GDB.CTR_CONTROL_POINT_CROSS_N",


We need to make sure the namings are ok.

shimoncohen · 2024-09-19T15:45:49Z

 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 /* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
+import crypto from 'crypto';


It seems that this package is deprecated.
Maybe we can use uuid instead?

This is dev-scripts. But, will change to node:crypto

shimoncohen · 2024-09-19T15:48:36Z

+        - x-api-key: []
+          x-user-id: []
+
+  /search/control/tiles:


I suggest splitting endpoints for querying tile and mgrs so we could have clearer and simpler API handling.

This route enables search Control Tiles via providing a MGRS Tile. It will result with all of the tiles that intersects with our Control Tiles.

shimoncohen · 2024-09-19T16:01:58Z

+
+const LAST_ELEMENT_INDEX = -1;
+
+const generateDisplayName = <T extends Tile | Item | Route>(


Please create an enum for the common used strings representing types and other entities.

I would like you to elaborate :)

… the pod

… built in module

… feat/feedback-api-redis

…rid-and-version-are-missing-in-geocodingqueryobject-in-the-response-mapco-4784 fix: added missing target_grid and version to the response

Feat/feedback api redis

NivGreenstein added 30 commits August 11, 2024 17:15

fix: fixed params type and removed unused code

5b22a0c

fix: added missig mgrs

bf25f8e

fix: changed mgrs to lowercase

93e1c93

feat: added NotImplementedError

e8d48ed

fix(tileRepository): fixed requested type

72bca0e

fix(tileManager): throw BadRequestError if both tile and mgrs are not…

7ce6ca7

… provided

fix(tileManager): throw NotImplementedError if mgrs is provided

0a7e459

fix(tileManager): throw BadRequestError tile is undefined but tries t…

cc32252

…o query it

feat(control/utils): extracted logic of geoContext query to a common …

ab96328

…reusable function

feat(control/constants): moved CONTROL_FIELDS to this file and create…

176fb1a

…d ELASTIC_KEYWORDS as exported const

fix(control/utils): moved additionalControlSearchProperties to this file

80667da

delete(elastic/utils): delete additionalControlSearchProperties

85c1342

delete(common/constants): removed CONTROL_FIELDS

0777861

feat: use geoContextQuery in all queries. use Elastic_keywords in sub…

a9daf2c

…tile query.

fix(tileRepository): updated imports

f03c666

fix(control/utils): fixed returned type of geoContextQuery

e7e1c30

feat(control/constants): added layerName and tiedTo to ELASTIC_KEYWORDS

6ef5843

delete(elastic/utils): removed unused imports

2aaa190

feat(itemQuery): changed query to new parameters

f76a470

fix(itemRepository): updated import

41c202b

fix(itemManager): updated manager

87c6516

fix(itemController): updated controller based on new openapi

4d5d951

feat(routeController): updated controller based on new openapi

2528bd8

fix(routeManager): updated imports based on types

23c8d81

fix(routeRepository): updated import

61c1697

fix(route query): updated query to use geoContextQuery

2e7ef58

fix(routeController): added missing geo_context_mode

2c57944

feat(common/utils): added Type util that infers snake_case interface …

026754b

…to camelCase interface

delete(common/interfaces): removed unused interface

49a280c

feat(item/queries): ItemQueryParams now extends converted snake-case …

a68ce86

…to camelCase CommonRequestParameters infered type

NivGreenstein and others added 3 commits September 19, 2024 14:34

Merge pull request #31 from MapColonies/bug/30-lookupcoordinates-targ…

ad94743

…et_grid-and-version-are-missing-in-geocodingqueryobject-in-the-response-mapco-4784

feat(latLon.spec.ts): added test should return error when cronPattern…

97415fe

… is not defined

chore: changed version to 0.1.0-prealpha.4

9916991

shimoncohen requested changes Sep 19, 2024

View reviewed changes

Niv Greenstein and others added 5 commits September 22, 2024 15:11

fix: changed s3 files download location in order to mount emptyDir in…

f815de7

… the pod

fix: changed to node:crypto to specifically use the new nodejs crypto…

117ce76

… built in module

fix: added delete all indices before new init

4b2a521

fix: added mkdir to s3 downloads file

82cd127

fix: change 'name' to 'names' according to openapi

2577db4

NivGreenstein force-pushed the 0.1.0 branch from 6cd8d64 to 2577db4 Compare September 23, 2024 10:39

NatalieShaked and others added 14 commits September 23, 2024 14:13

fix: feedback sends to redis without adding time to the response

e2ca1b1

Merge branch '0.1.0' of https://github.com/MapColonies/geocoding into…

4ad4d0c

… feat/feedback-api-redis

fix: added missing target_grid and version to the response

2efa015

Merge pull request #32 from MapColonies/30-lookupcoordinates-target_g…

a9aa8db

…rid-and-version-are-missing-in-geocodingqueryobject-in-the-response-mapco-4784 fix: added missing target_grid and version to the response

fix: minor fixes for code clearness

e5dd67f

Merge pull request #15 from MapColonies/feat/feedback-api-redis

c8e815c

Feat/feedback api redis

fix: app will work also if redis was not able to connect

84e71e9

fix: added site to env vars

9422a04

feat: created GenericGeocodingResponse

4628395

fix: changed from ControlResponse to GenericGeocodingResponse

4454246

delete: removed ControlResponse

73bb042

fix: changed type from QueryResult to GenericGeocodingResponse

d83f18b

fix: fixed all tests to right types

e95c4e9

fix: fixed latLonDal init and prevent it from being created 3 times

c340fd4

NivGreenstein merged commit 8d9694c into master Sep 30, 2024

NivGreenstein mentioned this pull request Sep 30, 2024

Revert "0.1.0" #34

Merged

NivGreenstein mentioned this pull request Oct 13, 2024

feat: new architecture (0.1.0) #35

Merged

NivGreenstein deleted the 0.1.0 branch October 19, 2024 08:10

NivGreenstein restored the 0.1.0 branch October 19, 2024 08:10

syncush deleted the 0.1.0 branch October 29, 2024 12:47


		const LAST_ELEMENT_INDEX = -1;

		const generateDisplayName = <T extends Tile \| Item \| Route>(

Conversation

NivGreenstein commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NivGreenstein Sep 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NivGreenstein commented Sep 10, 2024 •

edited

Loading

NivGreenstein Sep 22, 2024 •

edited

Loading