Skip to content

test: handlers unit & integartion tests (MAPCO-8344)#31

Merged
CL-SHLOMIKONCHA merged 10 commits into
feat/ingestion-tasks-workflowfrom
test/ingestion-tasks-workflow
Dec 23, 2025
Merged

test: handlers unit & integartion tests (MAPCO-8344)#31
CL-SHLOMIKONCHA merged 10 commits into
feat/ingestion-tasks-workflowfrom
test/ingestion-tasks-workflow

Conversation

@CL-SHLOMIKONCHA

Copy link
Copy Markdown
Contributor

This PR is adjust and cover for new ingestion tasks workflow feat branch - includes unit & integration tests separated for teach handler (Ingestion, Export & Seeding)

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

@razbroc razbroc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't enjoy this at all.

Comment thread tests/integration/tasks/export/taskManager.spec.ts
Comment thread tests/integration/tasks/ingestion/taskManager.spec.ts
Comment thread tests/unit/tasks/handlers/ingestionJobHandler.spec.ts Outdated
Comment thread tests/integration/tasks/ingestion/taskManager.spec.ts
Comment thread tests/integration/tasks/seed/taskManager.spec.ts
Comment thread tests/unit/tasks/handlers/ingestionJobHandler.spec.ts
Comment thread tests/unit/tasks/handlers/jobHandlerFactory.spec.ts Outdated
Comment thread tests/unit/tasks/handlers/jobHandler.spec.ts Outdated
Comment thread tests/unit/tasks/handlers/jobHandler.spec.ts Outdated
Comment thread tests/unit/tasks/handlers/taskHandler.spec.ts Outdated

@razbroc razbroc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this

Comment thread src/tasks/handlers/ingestion/ingestionHandler.ts Outdated
Comment thread src/tasks/handlers/seed/seedHandler.ts Outdated
Comment thread src/tasks/handlers/jobHandler.ts
Comment thread src/tasks/handlers/ingestion/ingestionHandler.ts
Comment thread tests/unit/tasks/handlers/baseJobHandler.spec.ts
Comment thread tests/integration/tasks/ingestion/taskManager.spec.ts
@CL-SHLOMIKONCHA CL-SHLOMIKONCHA changed the title test: handlers unit & integartion tests test: handlers unit & integartion tests (MAPCO-8344) Dec 22, 2025
@razbroc

razbroc commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

almot done very nice WP!!!
image
(yes this is you)

@razbroc razbroc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg wp

@CL-SHLOMIKONCHA
CL-SHLOMIKONCHA merged commit 85db7d1 into feat/ingestion-tasks-workflow Dec 23, 2025
8 checks passed
@CL-SHLOMIKONCHA
CL-SHLOMIKONCHA deleted the test/ingestion-tasks-workflow branch December 23, 2025 07:50
CL-SHLOMIKONCHA added a commit that referenced this pull request Dec 23, 2025
* feat: support new ingestion workflow

* feat: implement initial task ready logic for ingestion workflow

* feat: implemented validation workflow for ingestion

* feat: added procesable task logic

* feat: added support for proceedable job and change is job completed logic

* style: fix lint errors

* chore: added info log for unprocessable job & removed irrelevant export

* fix: pr comments

* feat: added support for seed workflow with seed job handler

* chore: fixed lint errors

* chore: changed create merge tasks naming in task flow

* chore: added dedicated type for isProceedable response

* chore: fix lint warnings

* test: handlers unit & integartion tests (MAPCO-8344) (#31)

* test: added and adjust unit tests

* test: added test foreach of handler

* test: adjust unit test for each of the handlers

* test: integration test fix

* test: adjust unit & inegration for each handler

* style: fixed lint errors

* chore: handle task validation parameter schema & adjust tests

* chore: fixed lint errors

* refactor: task proceed rule implementation

* style: added ignore eslint warning nullish operator

* style: removed irrelevant comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants