feat: add useHttpGet flag to S3 configuration #166
Merged
Conversation
CL-SHLOMIKONCHA
requested changes
Apr 15, 2026
…nd update related components
CL-SHLOMIKONCHA
requested changes
Apr 20, 2026
CL-SHLOMIKONCHA
requested changes
Apr 20, 2026
CL-SHLOMIKONCHA
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for configuring the use of HTTP GET requests with S3 storage through a new
useHttpGet/use_http_getoption. The change is implemented across configuration files, environment variable templates, the main codebase, and tests to ensure the new option is properly handled and tested.Configuration and environment variable support:
useHttpGetto the S3 configuration inconfig/default.jsonand mapped it to theS3_USE_HTTP_GETenvironment variable inconfig/custom-environment-variables.json. [1] [2]helm/templates/configmap.yaml,helm/values.yaml) to support and expose theuseHttpGetoption for S3 storage. [1] [2] [3]Codebase enhancements:
IS3ConfigandIS3Sourceinterfaces to include theuseHttpGet/use_http_getproperty, and updated theS3Sourceclass to pass this property into the cache source definition. [1] [2] [3] [4]Testing improvements:
useHttpGetproperty in S3 configuration, including new test cases for layers with both true and false values. [1] [2] [3] [4]